-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🏗 Use Docker containers in CircleCI builds, and other optimizations #35176
🏗 Use Docker containers in CircleCI builds, and other optimizations #35176
Conversation
8c862ad
to
d7513ea
Compare
ac8722a
to
767b319
Compare
767b319
to
d3018f8
Compare
Looping in @kristoferbaxter who requested that this be discussed during design review before we actually check in the change. @danielrozenberg Would it be possible to write up an I2I for the move to docker containers and run it by |
An I2I is a bit of an overkill - switching how we run our CI tasks is an implementation detail, there's no feature changes here. The discussion on flakes is here above and I think that's the only thing that seriously needs discussing :) |
d3018f8
to
e538b86
Compare
4806fe8
to
39a295e
Compare
68e6042
to
1f995d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved skipping tests.
This PR makes several optimizations to CircleCI builds that shave a "large PR" (i.e., one with the
RUNTIME
build target) from ~20 to ~16 minutes. Together with upcoming optimizations to Bundle Size, Unit Tests, and End-to-End Tests we estimate this can go down to ~12 minutes eventuallyThis PR:
npm ci
amp
command when running in a CI environment