Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I2D: test-status checks #35247

Closed
rileyajones opened this issue Jul 15, 2021 · 2 comments
Closed

I2D: test-status checks #35247

rileyajones opened this issue Jul 15, 2021 · 2 comments
Labels
INTENT TO DEPRECATE Proposes deprecating an existing AMP feature.

Comments

@rileyajones
Copy link
Contributor

Summary

After tests run in CI they report a status to our custom test-status bot which then shows a message on the PR.
image

This information is redundant with the information displayed by the CircleCI checks while requiring the maintenance of both the bot and integration with it.
image

Motivation

CircleCI provides a lot more information about tests and their statuses in a cleaner way without requiring as much of a maintenance burden.

Impact on Existing Users

Realistically none. Some developers may need to discover failed tests differently.

Alternative Implementation

Do not remove the bot and work to reduce the tech debt it contains.

Additional Context

No response

Notifications

/cc @ampproject/wg-approvers

@rileyajones rileyajones added the INTENT TO DEPRECATE Proposes deprecating an existing AMP feature. label Jul 15, 2021
@kristoferbaxter
Copy link
Contributor

Approved!

@rsimha
Copy link
Contributor

rsimha commented Jul 15, 2021

+1, approved 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INTENT TO DEPRECATE Proposes deprecating an existing AMP feature.
Projects
None yet
Development

No branches or pull requests

3 participants