Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃彈 馃毊 Remove test-status bot reporting #35249

Merged
merged 4 commits into from
Jul 19, 2021
Merged

馃彈 馃毊 Remove test-status bot reporting #35249

merged 4 commits into from
Jul 19, 2021

Conversation

rileyajones
Copy link
Contributor

Since moving to CircleCI, the test-status bot has become more of a maintenance burden than a help due to the CircleCI GitHub integration providing the same information.

#35247

@amp-owners-bot amp-owners-bot bot requested a review from dvoytenko July 15, 2021 21:20
@amp-owners-bot
Copy link

amp-owners-bot bot commented Jul 15, 2021 •
edited
Loading

Hey @rsimha! These files were changed:

build-system/common/utils.js
build-system/pr-check/checks.js
build-system/pr-check/cross-browser-tests.js

Hey @estherkim! These files were changed:

build-system/tasks/e2e/index.js
build-system/tasks/e2e/mocha-dots-reporter.js

danielrozenberg
danielrozenberg approved these changes Jul 16, 2021
View reviewed changes
Copy link
Member

@danielrozenberg danielrozenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after removing the debugging leftovers. Goodnight, sweet bot!

src/global.d.ts Outdated Show resolved Hide resolved
testing123 Outdated Show resolved Hide resolved
rsimha
rsimha approved these changes Jul 16, 2021
View reviewed changes
Copy link
Contributor

@rsimha rsimha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup. LGTM after one more deletion.

And appreciate all your past work on this, @danielrozenberg!

build-system/tasks/report-test-status.js Show resolved Hide resolved
estherkim
estherkim approved these changes Jul 16, 2021
View reviewed changes
Copy link
Collaborator

@estherkim estherkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you want to delete https://github.com/ampproject/amp-github-apps/tree/main/test-status too? 馃槵

And we can turn down the app engine

@rileyajones
Copy link
Contributor Author

rileyajones commented Jul 16, 2021 •
edited
Loading

@estherkim we're planning on waiting a couple days before turning down the bot incase someone complains (can't really imagine that happening).

I'll put up a PR deleting the code in amp-github-apps and link it here though.

ampproject/amp-github-apps#1446

@rileyajones rileyajones mentioned this pull request Jul 16, 2021
Merged
@rsimha rsimha removed the request for review from dvoytenko July 16, 2021 18:02
@rileyajones rileyajones enabled auto-merge (squash) July 19, 2021 20:05
@rileyajones rileyajones merged commit 21a9024 into ampproject:main Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielrozenberg danielrozenberg danielrozenberg approved these changes

@rsimha rsimha rsimha approved these changes

@estherkim estherkim estherkim approved these changes

Assignees
No one assigned
Labels
PR use: In Beta / Experimental PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rileyajones @danielrozenberg @rsimha @estherkim @ampprojectbot