Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appnexus Ads are broken #3589

Closed
mkhatib opened this issue Jun 15, 2016 · 2 comments · Fixed by #4214
Closed

Appnexus Ads are broken #3589

mkhatib opened this issue Jun 15, 2016 · 2 comments · Fixed by #4214

Comments

@mkhatib
Copy link
Contributor

mkhatib commented Jun 15, 2016

App Nexus ads in amp seems to be broken since awhile with the following error:

Uncaught TypeError: Cannot read property 'anq' of undefined

image

@mkendall07 any idea if you can take a look and see if you can fix this? You can reproduce this by running gulp and navigating to ads.amp.max.html example.

@mkhatib mkhatib added this to the Fixit - Date TBD milestone Jun 15, 2016
@mkhatib mkhatib self-assigned this Jun 15, 2016
@mkendall07
Copy link
Member

Thanks for letting me know. I'll take a look

@mkendall07
Copy link
Member

This is just an issue with the ads.amp.html page and the 2 different ways that AppNexus ads are loaded. Because the "simple" ads are loaded first, our global context doesn't have a reference to the apntag object. Really these 2 different ad types should never be mixed. I can fix it by switching the order of the ads loading or just remove the first 2 ad spots...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants