♻️ [amp-story-page-attachment] revise cta text in docs #36426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @gmajoulet, @newmuis! These files were changed: |
gmajoulet
reviewed
Oct 27, 2021
| @@ -86,7 +80,7 @@ Contrast protection is automatically applied to ensure readability and a11y comp | |||
| <amp-story-page-outlink | |||
| layout="nodisplay" | |||
| theme="dark"> | |||
| <a href="https://www.google.com">Call To Action</a> | |||
| <a href="https://www.google.com"></a> | |||
There was a problem hiding this comment.
Should we keep the "Call to action" text here? I believe it can be used to configure the cta-text
There was a problem hiding this comment.
We decided to remove it since the default text is reflected in the image.
The following two examples include text corresponding to the example images.
There was a problem hiding this comment.
We still need to document how people can tweak the call to action, should we update the screenshot instead of removing the configuration?
gmajoulet
approved these changes
Nov 15, 2021
processprocess
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was not meant to be added to the docs for this component and can be deleted.
A comment is added about why the codepath is necessary in
renderOutlinkUIThe demo text is updated to reflect the text in the images.