Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨Allow link[rel=stylesheet] which points to the amp-story-1.0.css in a transformed amp document #36844

Merged
merged 7 commits into from
Nov 10, 2021
Merged

✨Allow link[rel=stylesheet] which points to the amp-story-1.0.css in a transformed amp document #36844

merged 7 commits into from
Nov 10, 2021

Conversation

erwinmombay
Copy link
Member

@erwinmombay erwinmombay commented Nov 8, 2021 •
edited
Loading

To better improve the performance of amp-story documents we would like to allow linking to the amp-story-1.0.css in a transformed document to specifically improve LCP.

This feature will be implemented in the amp-toolbox optimizer

@amp-owners-bot amp-owners-bot bot requested a review from amaltas November 8, 2021 15:25
@amp-owners-bot
Copy link

amp-owners-bot bot commented Nov 8, 2021 •
edited by ampprojectbot
Loading

Hey @ampproject/wg-caching! These files were changed:

validator/testdata/transformed_feature_tests/amp-story-css-link.html
validator/testdata/transformed_feature_tests/amp-story-css-link.out
validator/validator-main.protoascii

@erwinmombay erwinmombay changed the title Allow link[rel=stylesheet] which points to the amp-story-1.0.css in a transformed amp document ✨Allow link[rel=stylesheet] which points to the amp-story-1.0.css in a transformed amp document Nov 8, 2021
@erwinmombay
Allow link[rel=stylesheet] which points to the amp-story-1.0.css in a…
4d5383e 
… transformed amp document

To better improve the performance of amp-story documents we would like
to allow linking to the amp-story-1.0.css to specifically improve LCP.
@erwinmombay
allow rtv urls
f1e71e4
@erwinmombay
remove allowing rtv url for the css link
8b2e2a1
@erwinmombay
remove the rtv link
59841f4
jridgewell
jridgewell requested changes Nov 8, 2021
View reviewed changes
Copy link
Contributor

@jridgewell jridgewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add <link rel=stylesheet> support to the runtime before merging.

validator/validator-main.protoascii Outdated Show resolved Hide resolved
erwinmombay and others added 2 commits November 8, 2021 14:31
@erwinmombay
Copy link
Member Author

erwinmombay commented Nov 9, 2021 •
edited
Loading

added link[rel=stylesheet] detection in #36865

@erwinmombay
Copy link
Member Author

@jridgewell merged #36865 PTAL

@erwinmombay erwinmombay merged commit 78fed1a into ampproject:main Nov 10, 2021
@jshamble jshamble mentioned this pull request Nov 29, 2021
Closed
@mszylkowski mszylkowski mentioned this pull request Dec 6, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gregable Gregable Gregable approved these changes

@jridgewell jridgewell jridgewell approved these changes

@gmajoulet gmajoulet gmajoulet approved these changes

@amaltas amaltas Awaiting requested review from amaltas

@westonruter westonruter Awaiting requested review from westonruter

Assignees
No one assigned
Labels
PR use: In Beta / Experimental PR use: In LTS PR use: In Stable WG: caching
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@erwinmombay @Gregable @jridgewell @westonruter @gmajoulet @honeybadgerdontcare @ampprojectbot