Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Amp story page attachment] Refreshing page while attachment is open throws error. #37430

Closed
processprocess opened this issue Jan 20, 2022 · 1 comment · Fixed by #37431
Closed

[Amp story page attachment] Refreshing page while attachment is open throws error. #37430

processprocess opened this issue Jan 20, 2022 · 1 comment · Fixed by #37431
Assignees
@processprocess
Labels
P1: High Priority Type: Bug WG: stories

Comments

@processprocess
Copy link
Contributor

Description

When an inline attachment is open, it should still be open when the page is refreshed. An error is thrown. Since the openAttachment method was removed from amp-story-page.

Screen Shot 2022-01-20 at 10 37 46 AM

Reproduction Steps

  1. Open a story with an attachment such as /examples/amp-story/attachment.html.
  2. open an inline attachment.
  3. refresh page.

Relevant Logs

error-reporting.js:203 TypeError: _this6.activePage_.openAttachment is not a function
    at amp-story.js:949:28

Browser(s) Affected

No response

OS(s) Affected

all

Device(s) Affected

all

AMP Version Affected

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@processprocess processprocess

Labels
P1: High Priority Type: Bug WG: stories
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 [amp story page attachment] reopen attachment on refresh processprocess/amphtml
1 participant
@processprocess