Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMP Validator: Allow attribute 'fetchpriority' for link tag #38715

Open
buihoanghai opened this issue Mar 15, 2023 · 8 comments
Open

AMP Validator: Allow attribute 'fetchpriority' for link tag #38715

buihoanghai opened this issue Mar 15, 2023 · 8 comments

Comments

@buihoanghai
Copy link

Description

Im trying improve the LCP by adding attribute fetchpriority suggest by this article https://web.dev/priority-hints/
image

Alternatives Considered

Allow attribute 'fetchpriority' for link tag

Additional Context

No response

@erwinmombay
Copy link
Member

hmm let me check if we even allow for link elements currently

@buihoanghai
Copy link
Author

hi @erwinmombay any update?

@erwinmombay
Copy link
Member

now that our validators are back in sync we can probably add this.

@alanorozco could we get your feedback if this has any negative performance implications?

@banaag LMK if you have any thoughts on this on the validator side of things.

@westonruter
Copy link
Member

The fetchpriority attribute also (more importantly?) needs to be allowed on the img element as well.

could we get your feedback if this has any negative performance implications?

Just merely allowing the fetchpriority would allow sites to begin to use it. This is important for reducing LCP: https://web.dev/fetch-priority/

@erwinmombay
Copy link
Member

thanks for the input @westonruter , we are adding this to our current sprint

@banaag
Copy link
Contributor

banaag commented Aug 10, 2023

Validator changes have been submitted, next step is deployment.

@westonruter
Copy link
Member

It looks like the validator changes have been deployed, right?

@banaag
Copy link
Contributor

banaag commented Oct 13, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants