-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add warning in validator about the deprecation of using amp-ad without loading the extension #4140
Comments
It's not really required, but like all other extensions it would be good to include script to the page. |
Thanks @zhouyx! I think it was throwing off some folks as to how ads were working without the ads script :) I'll send a tiny PR to clarify here. |
Initially the ad code was part of the main runtime, but was moved to a separate include. Ideally documents would add the include directly, which would speed up loading, however we don't want to break everyone. Maybe we can leave this issue open as a TODO for the validator to emit warnings for pages that use |
Cool! I've clarified in a PR for doc. Assigning to you. |
I'd like to leave this open to add validation warnings about the same. I'll change the subject to no longer mention documentation as that's now in place. |
Warning should be live in a couple hours. |
Is <script async custom-element="amp-ad" src="https://cdn.ampproject.org/v0/amp-ad-0.1.js"></script> required for running ads? I didn't think so because ads just work without it? e.g. http://dfp-amp-testing-1185.appspot.com/amp_tests/dfp-image-layouts-fixed-demo.html
If not, should we update the documentation here ? https://github.com/ampproject/amphtml/blob/master/extensions/amp-ad/amp-ad.md#-amp-ad
The text was updated successfully, but these errors were encountered: