Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor amp-ad doc update about amp-ad script #4142

Merged
merged 1 commit into from Aug 1, 2016

Conversation

jasti
Copy link
Contributor

@jasti jasti commented Jul 20, 2016

Fixes #4140.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@jasti
Copy link
Contributor Author

jasti commented Jul 20, 2016

No, googleBOT. It's not and I've signed it.

@zhouyx
Copy link
Contributor

zhouyx commented Jul 20, 2016

LGTM, And good job on complaining to googleBOT!

@jasti
Copy link
Contributor Author

jasti commented Jul 30, 2016

@zhouyx Can you please merge this? I don't have auth to do it.

@lannka
Copy link
Contributor

lannka commented Jul 30, 2016

@jasti CLA didn't pass. I met the same issue when I signed using my Google corp account. Then I signed again with my personal gmail, it just worked.

@jasti
Copy link
Contributor Author

jasti commented Jul 31, 2016

Signed CLA with my personal email too (and added to GH).

@googlebot
Copy link

CLAs look good, thanks!

@zhouyx zhouyx merged commit f48af17 into ampproject:master Aug 1, 2016
ariangibson pushed a commit to Mixpo/amphtml that referenced this pull request Sep 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants