Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration test for rendering amp in a sandboxed iframe #5716

Closed
cramforce opened this issue Oct 20, 2016 · 2 comments
Closed

Add integration test for rendering amp in a sandboxed iframe #5716

cramforce opened this issue Oct 20, 2016 · 2 comments
Assignees
@zhouyx
Labels
P3: When Possible Type: Bug WG: infra
Milestone
Backlog Bugs

Comments

@cramforce
Copy link
Member

To avoid regressing #3005

Also see that bug for concrete sandbox attribute value.

The actual test can just run our basic integration test and add the sandbox. No need to an actual new test.
@ericlindley-g ericlindley-g added this to the Pending Triage milestone Oct 20, 2016
@adelinamart
Copy link
Contributor

@zhouyx can we triage this? Thanks

@zhouyx zhouyx removed this from the Fixit Week EOQ2 milestone Aug 22, 2017
@ampprojectbot ampprojectbot added this to the Backlog Bugs milestone Sep 12, 2017
@rsimha
Copy link
Contributor

rsimha commented Feb 6, 2018

@zhouyx Is this still relevant?

@zhouyx zhouyx closed this as completed Feb 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhouyx zhouyx

Labels
P3: When Possible Type: Bug WG: infra
Projects
None yet
Milestone
Backlog Bugs
Development

No branches or pull requests
7 participants
@cramforce @zhouyx @ericlindley-g @ampprojectbot @adelinamart @ampwafflebot @rsimha