Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No items in amp-list response throws non-user error #5962

Closed
cramforce opened this issue Nov 2, 2016 · 4 comments
Closed

No items in amp-list response throws non-user error #5962

cramforce opened this issue Nov 2, 2016 · 4 comments
Assignees
@cramforce

Comments

@cramforce
Copy link
Member

See this URL
https://cdn.ampproject.org/v/s/allrecipes.com/recipe/19165/creme-brulee/amp/?amp_js_v=5

I don't understand why this happens, as we do have a user().assert for this. Do we accidentally remove it?

CC @lannka @dvoytenko @erwinmombay
@cramforce
Copy link
Member Author

This is the null is not an object (evaluating 'c.items') error

@erwinmombay
Copy link
Member

double checked and the assert is definitely there. but yeah we do a typeof null == "object" // true and try to access the property

@erwinmombay
Copy link
Member

screen shot 2016-11-01 at 6 08 48 pm

@erwinmombay
Copy link
Member

erwinmombay commented Nov 2, 2016 •
edited

actual response is also null. should they be doing a 304?

screen shot 2016-11-01 at 6 12 56 pm

cramforce added a commit to cramforce/amphtml that referenced this issue Nov 2, 2016
@cramforce
Add null check to amp-list response.
0e7f97c 
Fixes ampproject#5962
@cramforce cramforce assigned cramforce and unassigned dvoytenko Nov 2, 2016
@cramforce cramforce mentioned this issue Nov 2, 2016
Merged
cramforce added a commit that referenced this issue Nov 2, 2016
@cramforce
Add null check to amp-list response. (#5967)
198665d 
Fixes #5962
Lith pushed a commit to Lith/amphtml that referenced this issue Dec 22, 2016
@cramforce
Add null check to amp-list response. (ampproject#5967)
2f923ad 
Fixes ampproject#5962
Lith pushed a commit to Lith/amphtml that referenced this issue Dec 22, 2016
@cramforce
Add null check to amp-list response. (ampproject#5967)
425c2fc 
Fixes ampproject#5962
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cramforce cramforce

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cramforce @erwinmombay @dvoytenko