-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revive amp-slides #5981
Comments
does this mean we would have to increment the version of the carousel? - or should we just remove slides documentation from there and move it to amp-slides? |
For now we'd just remove the docs. |
The
There is some usage of this script tag still on the web, though it's very small. |
if amp-slides is invalid amp we should just delete it? |
I thought the decision was to
? |
Correct. I believe we need to bring |
It's coming back as |
It should be the same as
<amp-carousel type=slides>
. Having the type turned out to be a terrible idea.We should then stop documenting the
type
attribute and eventually make a new version ofamp-carousel
that no longer supports it.The text was updated successfully, but these errors were encountered: