Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revive amp-slides #5981

Closed
cramforce opened this issue Nov 2, 2016 · 7 comments
Closed

Revive amp-slides #5981

cramforce opened this issue Nov 2, 2016 · 7 comments

Comments

@cramforce
Copy link
Member

It should be the same as <amp-carousel type=slides>. Having the type turned out to be a terrible idea.

We should then stop documenting the type attribute and eventually make a new version of amp-carousel that no longer supports it.

@camelburrito
Copy link
Contributor

does this mean we would have to increment the version of the carousel? - or should we just remove slides documentation from there and move it to amp-slides?

@cramforce
Copy link
Member Author

For now we'd just remove the docs. amp-carousel-0.1 will need to keep supporting type=slides. Version 1.0 can drop the support.

@Gregable
Copy link
Member

The <amp-slides> tag was removed from validation in October 2015. I don't see any remaining usage of it in my sampling. For reasons I cannot seem to find, we did leave in validation of the javascript extension, for example:

<script async custom-element='amp-slides' src='https://cdn.ampproject.org/v0/amp-slides-0.1.js'></script>

There is some usage of this script tag still on the web, though it's very small.

@camelburrito
Copy link
Contributor

if amp-slides is invalid amp we should just delete it?

CC @cramforce @dvoytenko

@cramforce
Copy link
Member Author

I thought the decision was to

  • undocument <amp-carousel type=slides>
  • and make amp-slides to what the above does

?

@dvoytenko
Copy link
Contributor

Correct. I believe we need to bring amp-slides back and deprecate <amp-carousel type=slides>

@aghassemi
Copy link
Contributor

It's coming back as amp-inline-gallery (and amp-stream-gallery would be the scrolling one)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants