Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google AdX ads directly within an AMP page #6604

Closed
BenErdos opened this issue Dec 11, 2016 · 4 comments
Closed

Google AdX ads directly within an AMP page #6604

BenErdos opened this issue Dec 11, 2016 · 4 comments

Comments

@BenErdos
Copy link

RE: amphtml/ads/google/adsense.md

Can this configuration also be used for implementing AdX (Google Ad Exchange) directly on the page?

If so should the type be changed to:

<amp-ad width=300 height=250 type="adsense" data-ad-client="ca-pub-2005682797531342" data-ad-slot="7046626912"> </amp-ad>
@jasti
Copy link
Contributor

jasti commented Dec 11, 2016

Yes.

@jasti jasti closed this as completed Dec 11, 2016
@BenErdos
Copy link
Author

Thanks Jasti, sorry my comment got clipped. so the type remains adesnse?

i.e. The only things to change are the data-ad-client and the data-ad-slot?

@jasti
Copy link
Contributor

jasti commented Dec 12, 2016

That's right. There is no specific type called AdX.

@BenErdos
Copy link
Author

Great thanks!

@snyk-bot snyk-bot mentioned this issue Dec 20, 2020
Open
This was referenced May 2, 2021
Open
Open
This was referenced May 13, 2021
Open
Open
Open
This was referenced May 22, 2021
Open
Open
This was referenced Jun 2, 2021
Open
Open
Open
Open
This was referenced Jun 16, 2021
Open
Open
This was referenced Jun 28, 2021
Open
Open
Open
Open
Open
This was referenced Jul 5, 2021
Open
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this issue Jul 15, 2021
Open
This was referenced Aug 23, 2023
Open
Open
Open
Open
@mohammed-ibra mohammed-ibra mentioned this issue Sep 2, 2023
Open
This was referenced Sep 9, 2023
Open
Open
This was referenced Sep 16, 2023
Open
Open
This was referenced Sep 24, 2023
Open
Open
Open
Open
Open
Open
This was referenced Oct 1, 2023
Open
Open
Open
This was referenced Oct 10, 2023
Open
Open
This was referenced Oct 19, 2023
Open
Open
This was referenced Oct 26, 2023
Open
Open
This was referenced Nov 17, 2023
Open
Open
Open
Open
Open
@mohammed-ibra mohammed-ibra mentioned this issue Mar 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jasti @BenErdos