Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split event-helper #8316

Closed
alanorozco opened this issue Mar 22, 2017 · 0 comments
Closed

Split event-helper #8316

alanorozco opened this issue Mar 22, 2017 · 0 comments
Assignees
@jridgewell
Labels
WG: runtime
Milestone
Fixit Week EOQ1

Comments

@alanorozco
Copy link
Member

event-helper contains functions that are dependent on the timer service.

It would be useful to split event-helper in two different modules, since listen, listenOnce, failedToLoad and isLoadErrorMessage are part of a low-dependency subset that can be used by standalone binaries that don't bootstrap the service mechanism (i.e. integration.js and ampcontext-lib.js).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jridgewell jridgewell

Labels
WG: runtime
Projects
None yet
Milestone
Fixit Week EOQ1
Development

No branches or pull requests
3 participants
@jridgewell @alanorozco @ampwafflebot