Remove timer dependency from event-helpers (listen, listenOnce) #8472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jridgewell
force-pushed
the
event-helper-remove-timer-dep
branch
3 times, most recently
from
ff6623b
to
2b78971
Compare
dvoytenko
approved these changes
Mar 29, 2017
| if (unlistenLoad) { | ||
| unlistenLoad(); | ||
| } | ||
| failedToLoad(eleOrWindow); |
There was a problem hiding this comment.
failedToLoad throws an exception, right? Not a huge fun of those methods. Could you please add a comment here and say that this method will rethrow the original error?
| * @param {!EventTarget} element | ||
| * @param {string} eventType | ||
| * @param {boolean=} opt_capture | ||
| * @param {number=} opt_timeout | ||
| * @param {function(!UnlistenDef)=} opt_cancel An optional function that, when |
There was a problem hiding this comment.
I suppose this is ok since this is relatively rare. But WDYT about cancellable promises? E.g. we could have a type extension with method cancel on the promise?
There was a problem hiding this comment.
I thought about doing this, but it would be exposing it in the wrong object. Ie, how promise do not have a #resolve or #reject, only the resolver gets access to them. If we had a deferred type, we could easily add it there:
/**
* @typedef {{
* resolve: function(*=),
* reject: function(*=),
* cancel: function(),
* promise: !Promise,
* }}
*/
let DeferredDef;
alanorozco
approved these changes
Apr 17, 2017
jridgewell
force-pushed
the
event-helper-remove-timer-dep
branch
from
4decc53
to
7fda6a5
Compare
It’s unused
This inverts the responsibility of calling the unlistener. Now, the caller can be given access the `unlisten` by passing a closure. The closure is called with `unlisten` as the param, giving the caller access. When the caller determines it is time to stop listening (due to timeout, etc), it can manually cleanup.
jridgewell
force-pushed
the
event-helper-remove-timer-dep
branch
from
7fda6a5
to
d9ec050
Compare
jridgewell
force-pushed
the
event-helper-remove-timer-dep
branch
from
497c5b2
to
021f606
Compare
DarXector
pushed a commit
to DarXector/amphtml
that referenced
this pull request
Apr 25, 2017
…roject#8472) * Remove opt_timeout from loadPromise It’s unused * Allow caller to call internal unlisten This inverts the responsibility of calling the unlistener. Now, the caller can be given access the `unlisten` by passing a closure. The closure is called with `unlisten` as the param, giving the caller access. When the caller determines it is time to stop listening (due to timeout, etc), it can manually cleanup. * lint * fix merge conflict * fix test * Fix tests
mrjoro
pushed a commit
to mrjoro/amphtml
that referenced
this pull request
Apr 28, 2017
…roject#8472) * Remove opt_timeout from loadPromise It’s unused * Allow caller to call internal unlisten This inverts the responsibility of calling the unlistener. Now, the caller can be given access the `unlisten` by passing a closure. The closure is called with `unlisten` as the param, giving the caller access. When the caller determines it is time to stop listening (due to timeout, etc), it can manually cleanup. * lint * fix merge conflict * fix test * Fix tests
KenneyE
pushed a commit
to spotxchange/amphtml
that referenced
this pull request
May 3, 2017
…roject#8472) * Remove opt_timeout from loadPromise It’s unused * Allow caller to call internal unlisten This inverts the responsibility of calling the unlistener. Now, the caller can be given access the `unlisten` by passing a closure. The closure is called with `unlisten` as the param, giving the caller access. When the caller determines it is time to stop listening (due to timeout, etc), it can manually cleanup. * lint * fix merge conflict * fix test * Fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This inverts the responsibility of calling the unlistener. Now, the
caller can be given access the
unlistenby passing a closure. Theclosure is called with
unlistenas the param, giving the calleraccess. When the caller determines it is time to stop listening (due to
timeout, etc), it can manually cleanup.
Fixes #8316.