New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure AMP animations use zero CPU when off screen #8499

Closed
jasti opened this Issue Mar 30, 2017 · 4 comments

Comments

@jasti
Collaborator

jasti commented Mar 30, 2017

Animations should be paused/ not started and never take up any CPU cycle when off screen.

@lannka

This comment has been minimized.

Collaborator

lannka commented Mar 30, 2017

Right now there're 2 ways to animate in AMP. CSS and amp-animation.

For CSS animation, we don't have much control right now. Except that we do restrict CSS animation in ads. We planned to pause CSS animation in ads once out of viewport, see #7846.

For amp-animation, we currently don't pause animation. @aghassemi had some ideas about triggering and pausing animation with visibility info.

@jasti jasti changed the title from Ensure amp-animations use zero CPU when off screen to Ensure CSS animations use zero CPU when off screen Mar 30, 2017

@jasti jasti changed the title from Ensure CSS animations use zero CPU when off screen to Ensure CSS/ amp animations use zero CPU when off screen Mar 30, 2017

@jasti jasti changed the title from Ensure CSS/ amp animations use zero CPU when off screen to Ensure CSS/ AMP animations use zero CPU when off screen Mar 30, 2017

@jasti jasti changed the title from Ensure CSS/ AMP animations use zero CPU when off screen to Ensure AMP animations use zero CPU when off screen Apr 3, 2017

@jasti jasti modified the milestones: Sprint H2 April, Sprint H1 April Apr 3, 2017

@aghassemi

This comment has been minimized.

Member

aghassemi commented Apr 3, 2017

The visibility conditions for amp-animation will be done as part of #8411 . Haven't though about how this can/does related to CSS animations.

@jasti

This comment has been minimized.

Collaborator

jasti commented Apr 3, 2017

That sounds good. The CSS ones will be handled in #7846.

@lannka

This comment has been minimized.

Collaborator

lannka commented Apr 4, 2017

OK, sounds we have separate trackers for the 2. Closing this now.

@lannka lannka closed this Apr 4, 2017

@lannka lannka removed the Type: Bug label Apr 4, 2017

@jasti jasti added this to Done in AMP Advertising Jun 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment