Design Review 2017-05-24 (relaxing variable substitution limits, autocomplete, amp-layout, lightbox z-index, amp-imgur)

[mrjoro]

Note that we will skip the 2017-05-17 design review.

The AMP Project holds weekly engineering design reviews on Wednesdays @ 1pm Pacific via video conference using Google Hangouts.

Participation by the entire AMP Project community is encouraged.

This issue will be updated by 1pm Pacific on the Monday before the design review with links to the design docs that will be discussed. Please read through the design docs that will be discussed before attending the design review.

If you have a design you'd like to bring to design review, please read through the guidelines. When you are ready to bring your design to design review (after following the guidelines) update the appropriate Design Review GitHub issue with a link to your design doc and a brief description by 1pm Pacific on Monday of the week you'd like to present your design.

If you are unable to make the 1pm Pacific time due to time zone issues but you have a design you would like to present please make a note of that and we will try to find a time that works.

[cvializ]

I'd like to briefly discuss #7168. I'm particularly interested in fielding @rudygalfi and @cramforce's perspectives.

[aghassemi]

#7972
#9487
#9405

[cvializ]

In addition to #7168 I'd like to add #8825

[aghassemi]

Carlos - Relaxing requirement for variable substitution only for origin

• What were the risk factors?
• Malte: no question that we should allow it.
• For links, whitelist was needed to avoid accidental leaking to others.
• Whitelist may not be needed for forms
• Consensus seems to that no need for whitelist and allow for all origins.

Carlos - Autocomplete in AMP

• Demo of autocomplete
• Few small fixes needed in amp-bind to make it prod read
• Malte: really cool, worried there might be nuances that justify a new extension.
• Accessibility questions, bolding the part that matches, etc...
• Hardcoded response list, etc..
• Consensus: We need this anyway but a semantic little extension about autocomplete would be great.

Ali - amp-layout

• What are the use-cases for this?
• Ali: cards, responsive-height that we want to support
• amp-div? No amp-layout is good.
• Dima: Let's investigate CSS grid as well

Ali - allow override for lightbox's z-index

• Agreed no issue with doing it.

Ali - amp-imgur

• 3p iframe is too heavy, either normal iframe if they send resize event or just render an image and link to imgur
• (later verified they do send resize message)