Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XHR errors are reported incorrectly #9501

Closed
cvializ opened this issue May 23, 2017 · 4 comments
Closed

XHR errors are reported incorrectly #9501

cvializ opened this issue May 23, 2017 · 4 comments
Assignees
@jridgewell
Labels
P2: Soon WG: runtime
Milestone
Sprint H1 June

Comments

@cvializ
Copy link
Contributor

cvializ commented May 23, 2017

Since the new errors are not an instance of an error object, when they are thrown by callers to the AMP error service, the service does not recognize them as a valid error. Possible fixes are returning to the mutated-error approach, or creating a custom error type decorated with the xhr data.

This error manifests itself as Error: [Object object] in the console.
@cvializ cvializ self-assigned this May 23, 2017
@cvializ cvializ added this to the Active Non-Sprint Tracked milestone May 23, 2017
@jridgewell
Copy link
Contributor

Already working on it. #9448

@cvializ
Copy link
Contributor Author

cvializ commented May 23, 2017

Cool

@cvializ cvializ closed this as completed May 23, 2017
@cvializ cvializ removed the Type: Bug label May 23, 2017
@jridgewell
Copy link
Contributor

Don't have an issue for it, so I'm going to reopen this.

@jridgewell jridgewell reopened this May 23, 2017
@jridgewell jridgewell assigned jridgewell and cvializ and unassigned cvializ May 23, 2017
@jridgewell jridgewell mentioned this issue May 23, 2017
Closed
@jridgewell
Copy link
Contributor

Fixed by #9574.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jridgewell jridgewell

Labels
P2: Soon WG: runtime
Projects
None yet
Milestone
Sprint H1 June
Development

No branches or pull requests
4 participants
@jridgewell @cvializ @ericlindley-g @ampwafflebot