Xhr#fetchJson now returns Response #9574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvializ
reviewed
May 25, 2017
| }); | ||
| return xhr.fetchJson('http://localhost:31862/get?k=v1') | ||
| .then(res => res.json()) | ||
| .then(res => { |
There was a problem hiding this comment.
nit: consider renaming this arg since it isn't a response, it's the result of the json() call
cvializ
suggested changes
May 25, 2017
| json() { | ||
| return Promise.resolve({different}); | ||
| }, | ||
| });.once(); |
| json() { | ||
| return Promise.resolve({}); | ||
| }, | ||
| });.once(); |
There was a problem hiding this comment.
Ditto (This looks unintentional)
| @@ -79,6 +79,7 @@ export class AmpAutoAds extends AMP.BaseElement { | |||
| }; | |||
| return xhrFor(this.win) | |||
| .fetchJson(configUrl, xhrInit) | |||
| .then(res => res.json()); | |||
jridgewell
force-pushed
the
xhr-fetchJson-response
branch
2 times, most recently
from
7841492
to
e0da2de
Compare
jridgewell
force-pushed
the
xhr-fetchJson-response
branch
2 times, most recently
from
26eb0b4
to
7fc7e42
Compare
jridgewell
force-pushed
the
xhr-fetchJson-response
branch
from
7fc7e42
to
c927b76
Compare
jridgewell
force-pushed
the
xhr-fetchJson-response
branch
from
f3f883f
to
e458067
Compare
jridgewell
force-pushed
the
xhr-fetchJson-response
branch
from
caeada0
to
042f8c6
Compare
|
Ping @cvializ. |
jridgewell
force-pushed
the
xhr-fetchJson-response
branch
from
d7b156a
to
3e5cdaa
Compare
cvializ
approved these changes
Jun 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial for #9448.