Support version other than 0.1 in testing/building #9642
Comments
ampwafflebot
added
Type: Bug
WG: infra
Type: Feature Request
and removed
Type: Bug
labels
torch2424
added a commit
to torch2424/amphtml
that referenced
this issue
Jun 7, 2017
This is because of: ampproject#9642 , Was going to fix this myself, but it is currently in PR at: ampproject#9730
camelburrito
pushed a commit
that referenced
this issue
Jun 8, 2017
* Made a skeleton of all of the required files This skeeletons all of the required files for amp-sidebar v1 * Removed the test output,a nd updated the gulp file Now the gulp file will build and look for v1.0 of sidebar * Added some more skeleton to the main sidebar .js file Also, tested to ensure that the extension could be loaded and registered successfully * Updated the copyright year Suggested by @honeybadgerdontcare * Fixed Travis Linting errors * Fixed the typo on the alias declaration * Adding sidebar v1 exception to the dep check This is because of: #9642 , Was going to fix this myself, but it is currently in PR at: #9730 * Fixed PR comments Was my error in not realizing alias'ing was done for deprecated extensions * Added a note about declareExtensionVersionAlias, and declared versions in JS * Fixed Sidebar 0.1 tests Needed a different way of building the window since we are now introducing versioning to amp-sidebar * Fixed the gulpfile typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I was trying to remove amp-sticky-ad 0.1 folder as that version is deprecated. Then I found we use hardcoded path like
${extensionFolder}/0.1/...in lots of places. We need to support other version than 0.1.The text was updated successfully, but these errors were encountered: