New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test amp-ad works seamlessly when embedded inside of a PWA #9679
Comments
@choumx do we have an amp-ad example in your PWA shell? |
Confirmed with @choumx , 3P ads works: https://choumx.github.io/amp-pwa/content/21.amp.html |
Tested that an AMP and non-AMP ad render correctly without errors on our local PWA app. Try it out by going to @jasti @lannka Interestingly, I noticed that the AMP ad doesn't always render faster than the non-AMP ad in PWA with 2G network throttling on Chrome. Instead, the ad with the higher viewport position is rendered first. Might be due to shadow DOM streaming. |
It's possible we are falling back to using delayed fetch in this case which is not ideal. |
Reassigning to @lannka per comment above. Let me know if I can help. |
This issue hasn't been updated in awhile. @lannka Do you have any updates? |
Main thing to ensure is that the ads are loaded and viewability pings (active view) are fired for both AMP and non-AMP ads when they are delivered into an AMP page that is embedded inside of a shadow DOM within a PWA.
The text was updated successfully, but these errors were encountered: