Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow embed to have services that its parent lacks #10122

Merged
merged 2 commits into from Jun 27, 2017
Merged

Allow embed to have services that its parent lacks #10122

merged 2 commits into from Jun 27, 2017

Conversation

dreamofabear
Copy link

Partial for #9679.

  • Avoid throwing dev error when FIE doc has an extension service that its parent doesn't, e.g. AmpFormService if the embed includes amp-form.
  • Add A4A native/non-native examples from ABE to a4a.amp.html.

/to @lannka

@dreamofabear dreamofabear requested a review from lannka June 23, 2017 19:13
@dreamofabear
Copy link
Author

@lannka Friendly 🏓

@dreamofabear dreamofabear merged commit 5bb8318 into ampproject:master Jun 27, 2017
@dreamofabear dreamofabear deleted the adopt-service-fix branch June 27, 2017 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lannka lannka lannka approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dreamofabear @lannka @googlebot