[amp-sidebar 1.0] [Toolbar] Added Tests for Current Toolbar functionality #10084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
create new file for testing toolbar.js |
| @@ -0,0 +1,243 @@ | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
rename to test-toolbar.js
| import {timerFor} from '../../../../src/services'; | ||
| import {toggleExperiment} from '../../../../src/experiments'; | ||
| import * as sinon from 'sinon'; | ||
| import '../amp-sidebar'; |
There was a problem hiding this comment.
shouldn't this import toolbar?
There was a problem hiding this comment.
Toolbar requires and amp-sidebar element to be instantiated. So we need to create one for toolbar to work
There was a problem hiding this comment.
Stub one or more dummy amp-sidebar element(s), and test that is ideally how unit tests should work.
camelburrito
approved these changes
Jun 26, 2017
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #9985
Thais creates some basic unit tests for the added functionality of toolbar. Except for reaming features and styling.