Tighten types related to element attribute modification. #10091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wassgha Please review :) |
|
@cramforce Sorry, notification slipped by, will review now! |
wassgha
approved these changes
Jun 22, 2017
| */ | ||
| export function getAttributesFromConfigObj(configObj) { | ||
| if (!configObj['attributes']) { | ||
| return {}; | ||
| return dict(); | ||
| } | ||
| if (!isObject(configObj['attributes']) || isArray(configObj['attributes'])) { |
There was a problem hiding this comment.
Is this still enough to qualify for JsonObject? Also, might need to change the warning text.
There was a problem hiding this comment.
Since this is a not, it is actually sound. Unfortunately it is essentially impossible to detect the correct type at runtime. We do have cases that definitely get it now.
My changes for now, try to limit themselves to cases that the type system can detect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #9876