Lightbox 2.0: be able to expand overflown caption #10105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muxin
force-pushed
the
lightbox-overflown-caption
branch
from
20de636
to
6b37713
Compare
muxin
force-pushed
the
lightbox-overflown-caption
branch
from
6b37713
to
f3f7941
Compare
aghassemi
suggested changes
Jun 23, 2017
| opacity: 1; | ||
| transition: opacity 1s; | ||
| } | ||
|
|
||
| .i-amphtml-lbv-desc-box.standard { | ||
| max-height: 100px; |
There was a problem hiding this comment.
using a unit tied to font-size will be better here. Maybe something around 7rem;?
There was a problem hiding this comment.
Yeah, but I think using em could also be fine? It's the size of the description box after all.
There was a problem hiding this comment.
we should avoid em since it is relative to ancestor's font-size. Given lightbox-viewer is always child of body, it does not matter much in this case but rem is preferred.
| * @private | ||
| */ | ||
| toggleDescriptionOverflow_() { | ||
| if (this.descriptionBox_.classList.contains('standard')) { |
There was a problem hiding this comment.
use vsyn and do the scrollHeight clientHeight reads in the measure block and then mutate
aghassemi
reviewed
Jun 23, 2017
| opacity: 1; | ||
| transition: opacity 1s; | ||
| } | ||
|
|
||
| .i-amphtml-lbv-desc-box.standard { | ||
| max-height: 6em; |
aghassemi
reviewed
Jun 23, 2017
| if (this.descriptionBox_.classList.contains('standard')) { | ||
| this.descriptionBox_.classList.remove('standard'); | ||
| this.descriptionBox_.classList.add('overflow'); | ||
| let descBoxHeight = -1, descTextAreaHeight = -1; |
There was a problem hiding this comment.
let's use the state provided by vsyn to hold there values
measure: state => {
state.foo = 'bar';
},
mutate: state => {
state.foo
}
aghassemi
approved these changes
Jun 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial for #9970, more about transition coming in another PR