add dict-string-keys rule
#10107
Merged
add dict-string-keys rule
#10107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cramforce
requested changes
Jun 23, 2017
| return; | ||
| } | ||
|
|
||
| arg1.properties.forEach(function(prop) { |
There was a problem hiding this comment.
Could you make this recurse if the value is also an object literal?
Basically:
If value is object literal, also check that all its keys are literals.
There was a problem hiding this comment.
doh, yeah forgot about that
There was a problem hiding this comment.
@cramforce done. unfortunately if the the value is a reference (Identifier node) i can't really look it up and recursively check the reference (if its an array or object and its values/keys)
| } | ||
|
|
||
| arg1.properties.forEach(function(prop) { | ||
| if (!prop.key.raw) { |
There was a problem hiding this comment.
if the Key Node has a "raw" property then it is a string literal (value will be the quoted string), else it will have a name property
enforces that the keys of the object passed into `dict` has to be strings and should be quoted.
erwinmombay
force-pushed
the
dict-string-keys
branch
from
0378cae
to
77faece
Compare
cramforce
approved these changes
Jun 26, 2017
cramforce
added a commit
to cramforce/amphtml
that referenced
this pull request
Jul 2, 2017
We enforce via the linter (ampproject#10107) that arguments to `dict` are object literals. So, there is no need to copy. Part of ampproject#9876
cramforce
added a commit
that referenced
this pull request
Jul 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enforces that the keys of the object passed into
dicthas to bestrings and should be quoted.
Fixes #10094