Small fixes in amp-anim #10114
Merged
Small fixes in amp-anim #10114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Don't allocate image in constructor. Wait until build time when it is needed. - Assign an actual image in un-layout instead of assigning `''` to src which actually tries to load the current document as an image.
cramforce
force-pushed
the
amp-anim-drive-by
branch
from
b7ea148
to
ba2bc25
Compare
|
to @tiendt |
jridgewell
reviewed
Jun 23, 2017
| @@ -94,7 +96,8 @@ export class AmpAnim extends AMP.BaseElement { | |||
| /** @override */ | |||
| unlayoutCallback() { | |||
| // Release memory held by the image - animations are typically large. | |||
| this.img_.src = ''; | |||
| this.img_.src = 'data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///' + | |||
| 'yH5BAEAAAAALAAAAAABAAEAAAIBRAA7'; | |||
There was a problem hiding this comment.
Not the tiniest gif ever?
|
@tiendt Would you mind reviewing. Thanks. |
tiendt
approved these changes
Jun 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
''to src which actually tries to load the current document as an image.