Fixture setup timeout should be same as Mocha's #10140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jridgewell
reviewed
Jun 26, 2017
testing/iframe.js
Outdated
| @@ -152,7 +152,7 @@ export function createFixtureIframe(fixture, initialIframeHeight, opt_beforeLoad | |||
| }; | |||
| let timeout = setTimeout(function() { | |||
| reject(new Error('Timeout waiting for elements to start loading.')); | |||
| }, 2000); | |||
| }, process.env.TEST_TIMEOUT); | |||
There was a problem hiding this comment.
I don't know if process is propagated to the browser by Karma. We do a few things like this elsewhere, but I can't find it on my phone.
There was a problem hiding this comment.
It worked for me locally but I don't see precedence for this. Changed it to use ampTestRuntimeConfig instead.
rsimha
approved these changes
Jun 26, 2017
jridgewell
approved these changes
Jun 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9906 (hopefully).