Disable remote HTML usage for AdSense Delayed Fetch #10180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradfrizzell
suggested changes
Jun 28, 2017
| const meta = parentWindow.document | ||
| .querySelector('meta[name="amp-3p-iframe-src"]'); | ||
| if (!meta) { | ||
| return null; | ||
| } | ||
| if (opt_disallowCustom) { |
There was a problem hiding this comment.
should move this check above the previous one, so we don't do an unnecessary querySelector()
There was a problem hiding this comment.
I can't because I want to warn if remote HTML is specified so either way I need the query selector
| @@ -229,7 +231,8 @@ export class AmpAd3PImpl extends AMP.BaseElement { | |||
| // incrementLoadingAds(). | |||
| this.emitLifecycleEvent('adRequestStart'); | |||
| const iframe = getIframe(this.element.ownerDocument.defaultView, | |||
| this.element, undefined, opt_context); | |||
| this.element, this.element.getAttribute('type'), opt_context, | |||
There was a problem hiding this comment.
this.element.getAttribute('type') gets called three times in this class. Can we store the type as an attribute directly on the class instead?
bradfrizzell
approved these changes
Jun 28, 2017
| const meta = parentWindow.document | ||
| .querySelector('meta[name="amp-3p-iframe-src"]'); | ||
| if (!meta) { | ||
| return null; | ||
| } | ||
| if (opt_disallowCustom) { |
mrjoro
pushed a commit
to mrjoro/amphtml
that referenced
this pull request
Jun 30, 2017
* Disable remote HTML usage for AdSense Delayed Fetch * lint fixes * lint fixes * test fixes, PR feedback * fix test failures * test fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for configuring if network supports remote HTML usage via remoteHTMLDisabled option and enable for AdSense. Also ensure that Fast Fetch is allowed for such networks even if remote HTML is specified.