Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore links in code for link checker #10183

Merged
1 commit merged into from Jun 28, 2017
Merged

Ignore links in code for link checker #10183

1 commit merged into from Jun 28, 2017

Conversation

ghost
Copy link

@ghost ghost commented Jun 28, 2017

Link checker should ignore any links that are in <code>, like <code>http://www.site.com/doc/amp</code>.

@ghost ghost requested a review from rsimha June 28, 2017 19:29
rsimha
rsimha approved these changes Jun 28, 2017
View reviewed changes
Copy link
Contributor

@rsimha rsimha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This stemmed from check-links errors in #10182. I applied #10182 to my local branch, and tested with and without the changes in this PR. Failures without this PR went away after whitelisting <code> sections.

Thanks for making this change!

@ghost ghost merged commit 5905f9d into ampproject:master Jun 28, 2017
@ghost ghost deleted the fix-link-checker branch June 28, 2017 19:43
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rsimha @googlebot