Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add further info on Facebook app_id #10253

Merged
1 commit merged into from Jul 5, 2017
Merged

Add further info on Facebook app_id #10253

1 commit merged into from Jul 5, 2017

Conversation

ghost
Copy link

@ghost ghost commented Jul 4, 2017

Per #3719 (comment), added further info on Facebook app_id.

Per #3719 (comment), added further info on Facebook app_id.
@ghost ghost requested a review from ericlindley-g July 4, 2017 16:08
@ghost ghost merged commit f71919b into master Jul 5, 2017
@ghost ghost deleted the bpaduch-patch-social-share branch July 5, 2017 20:25
@88kbbq
Copy link

88kbbq commented Jul 6, 2017

No matter I use an app_id or page_id, I still see "Invalid App ID: 0"

@88kbbq
Copy link

88kbbq commented Jul 6, 2017

Ok, there were incorrect instructions that seemed to be fixed now. Don't use data-attribution, use data-param-app_id for Facebook amp-social-share.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants