Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test in test-integration-form.js #10273

Merged
merged 1 commit into from Jul 6, 2017

Conversation

dreamofabear
Copy link

Partial for #10187.

Chrome Mobile 44.0.2403 (Android 6.0.0) AmpForm Integration Submit result message should render messages with or without a template FAILED
Error: Timeout waiting for amp-img layout completes
at poll (/home/travis/build/ampproject/amphtml/testing/iframe.js:416:17 <- /tmp/f39cbc74ad9aae7cded8255aeb6b3152.browserify:57954:18)

https://travis-ci.org/ampproject/amphtml/jobs/250499019

Also create new form-events.js file with event names.

/to @aghassemi

@aghassemi
Copy link
Contributor

/to @cvializ

@aghassemi aghassemi requested a review from cvializ July 5, 2017 23:18
Copy link
Contributor

@aghassemi aghassemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dreamofabear dreamofabear merged commit ee2c0bc into ampproject:master Jul 6, 2017
@dreamofabear dreamofabear deleted the flaky-form-test branch July 6, 2017 00:25
@cvializ
Copy link
Contributor

cvializ commented Jul 6, 2017

LGTM2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants