Implement AMP.print() Action for Printing of Page #10319
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
jessanastasio
force-pushed
the
amp-print-support
branch
from
f632bb4
to
b98bf02
Compare
src/service/standard-actions-impl.js
Outdated
| if (!invocation.satisfiesTrust(ActionTrust.HIGH)) { | ||
| return; | ||
| } | ||
| self.print(); |
There was a problem hiding this comment.
instead of self, let's use const win = (node.ownerDocument || node).defaultView; , similar to handleAmpNavigateTo_
| }; | ||
| const windowApi = windowObj; | ||
| const printStub = sandbox.stub(windowApi, 'print'); | ||
| const invocation = {method: 'print', satisfiesTrust: () => true}; |
There was a problem hiding this comment.
I think now this needs a
target: {
ownerDocument: {
defaultView: windowApi,
},
},
to pass.
| @@ -233,6 +233,17 @@ describes.sandboxed('StandardActions', {}, () => { | |||
| expect(spy).to.be.calledWith('{foo: 123}'); | |||
| }); | |||
| }); | |||
|
|
|||
| it('should implement print', () => { | |||
| const windowObj = { | |||
There was a problem hiding this comment.
let's use a single variable ( windowApi ) for this.
|
@jessanastasio all good, thanks! Just reply 'I signed it!` here when CLA is signed and we can then merge. |
|
perfect! |
|
I signed it! |
|
CLAs look good, thanks! |
|
@jessanastasio, merged. |
Description
This PR adds the ability to print the current page by exposing a new
AMP.print()action instandard-actions-impl.js.Closes #10191
Screenshot (done in Chrome)