Fixes multisize creative centering. #10414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taymonbeal
suggested changes
Jul 13, 2017
| this.size_ = null; | ||
| this.initialSize_ = null; | ||
|
|
||
| /** @private {?{width, height}} */ |
taymonbeal
approved these changes
Jul 13, 2017
|
This is ready to be merged whenever. |
jridgewell
pushed a commit
that referenced
this pull request
Jul 18, 2017
* Iframe is resized to size of CREATIVE not SLOT. * Fixes case where creative size is not returned. * Expanded on comment. * Fixed type decl. * Fixed other type while at it. * Fixes SRA test.
erwinmombay
pushed a commit
that referenced
this pull request
Jul 18, 2017
* Iframe is resized to size of CREATIVE not SLOT. * Fixes case where creative size is not returned. * Expanded on comment. * Fixed type decl. * Fixed other type while at it. * Fixes SRA test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made in #10351 caused the creative to resize to the size of the slot rather than the creative, forcing the creative to appear left-top justified rather than centered when occupying a space smaller than the slot.