Clarify the CLA section of CONTRIBUTING #10416
Conversation
CONTRIBUTING.md
Outdated
|
|
||
| * If you are contributing code on your own behalf you can sign the ([individual CLA](https://developers.google.com/open-source/cla/individual) instantly online. | ||
| * If you are planning on contributing code on behalf of your company your company will need to agree to a [corporate CLA](https://developers.google.com/open-source/cla/corporate) if it has not already done so. Although this is a relatively straightforward process, it requires approval from an authorized signer at your company and a manual verification process, so to ensure you can get your code reviewed and merged quickly please start this process as soon as possible. | ||
| * If your company has already agreed to a corporate CLA you can indicate agreement to the CLA by having the appropriate person at your company add your email address added to the Google Group associated with your corporate CLA. |
There was a problem hiding this comment.
I always thought they also could allow all of @foo.com. Is that not the case?
There was a problem hiding this comment.
Ah; I didn't realize that was an option. I don't see that as an option in the corporate CLA form (it only has a line for "Authorized Contributors Group" that is looking for a Google Group), but perhaps that's an option later in the process. @aghassemi do you know?
There was a problem hiding this comment.
Talked to CLA team, blanket domain whitelist is not supported and not planned to be in near future either.
There was a problem hiding this comment.
@cramforce is this PR good to go?
CONTRIBUTING.md
Outdated
| @@ -101,9 +101,13 @@ For further detail on integrating third party services, fonts, embeds, etc. see | |||
|
|
|||
| ## Contributor License Agreement | |||
|
|
|||
| The AMP Project hosted at GitHub requires all contributors to sign a Contributor License Agreement ([individual](https://developers.google.com/open-source/cla/individual) or [corporation](https://developers.google.com/open-source/cla/corporate)) in order to protect contributors, users and Google in issues of intellectual property. | |||
| The AMP Project hosted at GitHub requires all contributors to sign a Contributor License Agreement in order to protect contributors, users and Google in issues of intellectual property. | |||
There was a problem hiding this comment.
Just "contributors and users"
CONTRIBUTING.md
Outdated
|
|
||
| When you create a Pull Request a check will be run to ensure that you have signed the CLA. Make sure that you sign the CLA with the same email address you associate with your commits (likely via the `user.email` Git config as described on GitHub's [Set up Git](https://help.github.com/articles/set-up-git/) page). | ||
| **We recommend signing the CLA *before* you send a pull request to avoid problems. Make sure that you sign the CLA with the same email address you associate with your commits (likely via the `user.email` Git config as described on GitHub's [Set up Git](https://help.github.com/articles/set-up-git/) page).** |
There was a problem hiding this comment.
Do you think making it a blocking step to submission is worth it? Might be better to lower initial barriers, since it is fine if this only happens eventually. Often corp CLAs can take a while.
There was a problem hiding this comment.
I don't think we should make it blocking; I've softened the language a bit here. WDYT?
This clarifies the CLA section a bit: