Makes data-vars- attribute work in amp-ad.
#10438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvoytenko
approved these changes
Jul 14, 2017
jridgewell
reviewed
Jul 14, 2017
| if (!startsWith(attr.name, 'data-') | ||
| // data-vars- is reserved for amp-analytics | ||
| // see https://github.com/ampproject/amphtml/blob/master/extensions/amp-analytics/analytics-vars.md#variables-as-data-attribute | ||
| || startsWith(attr.name, 'data-vars-')) { | ||
| continue; | ||
| } | ||
| attributes[dashToCamelCase(attr.name.substr(5))] = attr.value; |
There was a problem hiding this comment.
Why aren't we iterating the dataset? We could get rid of dashToCamelcase, #substr, and a startsWith:
const set = element.dataset;
for (const name in set) {
if (!startsWith(name, 'vars')) {
attributes[name] = set[name];
}
}
There was a problem hiding this comment.
A very good question. Reviewing this, I did a code search, and it looks like we are thoroughly underusing dataset. So I opted not to suggest it here. Perhaps we should be using it for this?
There was a problem hiding this comment.
I commented on another issue in the last year where they didn't use it because they needed the dash-case strings, which seemed fine. But in this case, I think it's the better choice.
There was a problem hiding this comment.
good stuff . addressed in PR #10543
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8852