Increase local timeout for amp-bind tests #10473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsimha
approved these changes
Jul 17, 2017
There was a problem hiding this comment.
I noticed that the travis build for this PR timed out, but it looks like that happened after the unit tests were run.
I wonder if it makes sense to increase the timeout to 5s instead of 4s to be fully sure the tests will pass, but I suppose there's the consideration of making tests fail fast, and not extending the duration of the build by too much if a test stalls.
In short, LGTM :)
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: #10404 (comment)
/to @rsimha-amp /cc @blueyedgeek