Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better test logging for local development and Travis runs #10479

Merged
merged 11 commits into from Jul 18, 2017
Merged

Better test logging for local development and Travis runs #10479

merged 11 commits into from Jul 18, 2017

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Jul 17, 2017

  • Replaces karma's dots reporter with super-dots on Travis. Now prints color coded check marks and crosses for passing / failing tests
  • Replaces karma's progress reporter with mocha if --testnames or --files is passed in to the command line. If enabled, this will print the name of each test being run and its pass / fail status. Default behavior remains unchanged.
  • Silences extremely verbose dependency install log messages for validator tests, since these currently account for more than half the size of a travis log. Errors will still be printed to the console.

#10482

@rsimha
Copy link
Contributor Author

rsimha commented Jul 17, 2017

/to @erwinmombay (overall), @honeybadgerdontcare (for validator changes)

@rsimha rsimha changed the title Better test logging for local development and Travis runs Better karma logging for local development and Travis runs Jul 17, 2017
@rsimha rsimha changed the title Better karma logging for local development and Travis runs Better test logging for local development and Travis runs Jul 17, 2017
@rsimha rsimha requested a review from dreamofabear July 17, 2017 22:55
@rsimha
Copy link
Contributor Author

rsimha commented Jul 17, 2017

/to @choumx

@rsimha
Copy link
Contributor Author

rsimha commented Jul 18, 2017

@erwinmombay, @honeybadgerdontcare: Pinging again, since this is now ready for merge.

icon: {
success : '✔',
failure : '✖',
ignore : '?'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add trailing ,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done here and the line below.

@rsimha rsimha merged commit db2e5b3 into ampproject:master Jul 18, 2017
@rsimha rsimha deleted the 2017-07-17-BetterLogging branch July 18, 2017 18:26
@dreamofabear
Copy link

@rsimha-amp How can you tell which tests are failing with this change? E.g. https://travis-ci.org/ampproject/amphtml/jobs/255041599

@rsimha
Copy link
Contributor Author

rsimha commented Jul 18, 2017

@choumx Hmm... I saw failure logs when I tested this out locally. Perhaps they're being silenced on Travis as a result of using super-dots instead of dots? I'll take a look right now, and if I can't see a cause, I'll revert back to dots on Travis.

Do you have a test that is known to fail? If not, I can try forcing a test to fail.

@rsimha
Copy link
Contributor Author

rsimha commented Jul 18, 2017

@choumx, I believe I've found the cause. Working on a fix.

Edit: Logged #10515
Edit 2: Fix has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants