New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better test logging for local development and Travis runs #10479
Conversation
/to @erwinmombay (overall), @honeybadgerdontcare (for validator changes) |
/to @choumx |
@erwinmombay, @honeybadgerdontcare: Pinging again, since this is now ready for merge. |
build-system/tasks/karma.conf.js
Outdated
icon: { | ||
success : '✔', | ||
failure : '✖', | ||
ignore : '?' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add trailing ,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done here and the line below.
@rsimha-amp How can you tell which tests are failing with this change? E.g. https://travis-ci.org/ampproject/amphtml/jobs/255041599 |
@choumx Hmm... I saw failure logs when I tested this out locally. Perhaps they're being silenced on Travis as a result of using Do you have a test that is known to fail? If not, I can try forcing a test to fail. |
dots
reporter withsuper-dots
on Travis. Now prints color coded check marks and crosses for passing / failing testsprogress
reporter withmocha
if--testnames
or--files
is passed in to the command line. If enabled, this will print the name of each test being run and its pass / fail status. Default behavior remains unchanged.#10482