Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info on placeholder & fallback behavior + more #10488

Merged
2 commits merged into from Jul 18, 2017
Merged

Add info on placeholder & fallback behavior + more #10488

2 commits merged into from Jul 18, 2017

Conversation

ghost
Copy link

@ghost ghost commented Jul 17, 2017

Fixes ampproject/amp.dev#618

  • Added documentation on placeholder & fallback behavior
  • Added embedded sample code - preview/source
  • Improved wording & formatting

Preview available at: https://ampproject-custom.firebaseapp.com/docs/reference/components/amp-twitter

@ghost ghost requested a review from dreamofabear July 17, 2017 23:59
@dreamofabear
Copy link

Thanks for improving this!

Do you think it's worth specifying this in the shared placeholders.md instead? Both amp-twitter and amp-list exhibit this behavior and more extensions probably will in the future.

@ghost
Copy link
Author

ghost commented Jul 18, 2017

@choumx - Good point. I've extracted the "common" info into the guide (see ampproject/amp.dev#626) and linked out to it. Once you approve that PR, I'll merge this one.

@ghost ghost merged commit 51afe75 into ampproject:master Jul 18, 2017
@ghost ghost deleted the fix-docs-issue-618 branch July 18, 2017 19:41
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants