New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a --skip mode for visual diff tests and make them PR blocking #10498
Conversation
/to @cramforce or @choumx for review, after which percy can be made a required check on Github. |
build-system/pr-check.js
Outdated
@@ -396,6 +400,9 @@ function main(argv) { | |||
if (buildTargets.has('RUNTIME')) { | |||
command.runUnitTests(); | |||
} | |||
} else { | |||
// Generates a blank Percy build to satisfy the required Github check. | |||
command.runVisualDiffTests(true /*pass*/); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
command.runVisualDiffTests(/* opt_pass */ true);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
build-system/pr-check.js
Outdated
@@ -280,9 +280,13 @@ const command = { | |||
timedExecOrDie( | |||
`${gulp} test --nobuild --saucelabs --integration --compiled`); | |||
}, | |||
runVisualDiffTests: function() { | |||
runVisualDiffTests: function(opt_pass) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
opt_skip
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Fixes #10164