Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a visual diff test for access controlled articles #10511

Merged
merged 1 commit into from Jul 19, 2017
Merged

Add a visual diff test for access controlled articles #10511

merged 1 commit into from Jul 19, 2017

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Jul 18, 2017 •
edited

This PR can serve as an example for others who want to add new visual tests.

#10155

@rsimha rsimha self-assigned this Jul 18, 2017
@rsimha rsimha requested a review from dreamofabear July 18, 2017 21:08
@rsimha
Copy link
Contributor Author

rsimha commented Jul 19, 2017

/to @choumx

@rsimha rsimha merged commit ca48a1f into ampproject:master Jul 19, 2017
@rsimha rsimha deleted the 2017-07-18-AddVisualTest branch July 19, 2017 18:10
@rsimha rsimha mentioned this pull request Jul 19, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamofabear dreamofabear dreamofabear approved these changes

Assignees

@rsimha rsimha

Labels
cla: yes PR use: In Beta / Experimental PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rsimha @dreamofabear @googlebot @ampprojectbot