Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up empty blocks with backticks during check-links #10579

Merged
merged 1 commit into from Jul 21, 2017
Merged

Clean up empty blocks with backticks during check-links #10579

merged 1 commit into from Jul 21, 2017

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Jul 21, 2017

Fixes #10578
Unblocks #10089

@rsimha rsimha requested a review from zhouyx July 21, 2017 19:24
@rsimha rsimha self-assigned this Jul 21, 2017
zhouyx
zhouyx approved these changes Jul 21, 2017
View reviewed changes
Copy link
Contributor

@zhouyx zhouyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

@rsimha
Copy link
Contributor Author

rsimha commented Jul 21, 2017

@zhouyx, with this fix, you don't need to whitelist anything.

screenshot from 2017-07-21 15 28 49

@zhouyx
Copy link
Contributor

zhouyx commented Jul 21, 2017

Yes! I already ran the test : ) I'll ask the PR author to rebase once this is merged 😄

@rsimha rsimha merged commit 34a3fb8 into ampproject:master Jul 21, 2017
@rsimha rsimha deleted the 2017-07-21-Backticks branch July 21, 2017 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhouyx zhouyx zhouyx approved these changes

Assignees

@rsimha rsimha

Labels
cla: yes PR use: In Beta / Experimental PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rsimha @zhouyx @googlebot @ampprojectbot