Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent false resizing in a long document #10590

Merged
merged 1 commit into from Jul 24, 2017
Merged

Prevent false resizing in a long document #10590

merged 1 commit into from Jul 24, 2017

Conversation

robinpokorny
Copy link
Member

  • Limit resizing in the last 15% to 1000px.
  • Add test for last 1000px.
  • Add test for last 15% but not last 1000px.

Fixes #9565

@robinpokorny robinpokorny force-pushed the prevent-false-resizing-in-long-document branch from 5c013c2 to 46a2afb Compare July 24, 2017 11:29
jridgewell
jridgewell approved these changes Jul 24, 2017
View reviewed changes
Copy link
Contributor

@jridgewell jridgewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @dvoytenko

@jridgewell jridgewell merged commit 62f53c3 into ampproject:master Jul 24, 2017
@robinpokorny robinpokorny deleted the prevent-false-resizing-in-long-document branch July 24, 2017 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jridgewell jridgewell jridgewell approved these changes

@dvoytenko dvoytenko dvoytenko approved these changes

Assignees
No one assigned
Labels
cla: yes PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@robinpokorny @jridgewell @dvoytenko @googlebot @ampprojectbot