[amp-sidebar 1.0][Toolbar] Added State classes to Sidebar 1.0's Toolbar, Removed toolbar-only #10601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvoytenko
suggested changes
Jul 25, 2017
|
@dvoytenko Updated the MD file to the current sidebar implementation. cc @bpaduch Could you take a quick look at the amp-sidebar-1.0.md file to ensure it is reading okay? Thanks! |
dvoytenko
approved these changes
Jul 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
amp-sidebar-toolbar-target-shown, andamp-sidebar-toolbar-target-hiddento the original<nav toolbar="" toolbar-target="">, on show/hide of the toolbar target.toolbar-onlyattribute, until we have a request for it, or more discussion otherwise.Screenshot