Simplify ActionTrust to two tiers #10633
Conversation
|
/to @aghassemi /cc @cramforce |
| ActionTrust.MEDIUM); | ||
| // Only require ActionTrust.LOW for video actions to defer to platform | ||
| // specific handling (e.g. user gesture requirement for unmuted playback). | ||
| video.registerAction('play', |
There was a problem hiding this comment.
let's keep all of these at HIGH as well. Aside from unmuted play, rest need to be HIGH regardless.
There was a problem hiding this comment.
@aghassemi Malte suggested that we should just defer to the browser for video actions to allow different handling on desktop vs. mobile. WDYT?
There was a problem hiding this comment.
I see, works as long as AMP and platform's idea of good UX don't differ in regards to these actions. One concern is unmute on desktop (without high trust actions) where AMP can so "no no" but platform can say "yes". But both Safari and Chrome are aligning desktop and mobile policies now so I am okay with allowing platform to handle this (can't think of any other issue beside unmute either)
There was a problem hiding this comment.
@aghassemi — can you elaborate on this? Are there conditions where unmuted playback could happen without user action?
There was a problem hiding this comment.
Not at the moment since we don't have any LOW trust events. But since we are keeping unmute at LOW, if we ever expose a LOW trust event (e.g. onload for amp-list?) then on certain platforms unmuted playback can happen.
Fixes #10166 and #9953.
Discussed with @ericlindley-g.