Fix wrong event name amp-carousel-next -> amp-carousel-prev #10640
Conversation
|
/cc @rsimha-amp: We have a failing link check again. |
|
That's likely due to the fact that it's a relative link, or due to the page anchor. Try using a full link. |
|
This is a pretty trivial change; any objection to just merging it? |
|
It'll fail new builds on master, till fixed. |
There was a problem hiding this comment.
The issue stems from the fact that it's an incorrect link. You'll need to replace /extensions/amp-analytics/analytics-vars.md#fromslide with ../amp-analytics/analytics-vars.md#fromslide.
I just ran this locally, and the fix works. To test this out yourself, run gulp check-links --files extensions/amp-carousel/amp-carousel-analytics.md.
Edit: Found the real problem.
|
Test results before and after fixing the problematic link: https://gist.github.com/rsimha-amp/c63b519ab33ecbedd5d0540ba446afcb |
|
@mrjoro, the link checker seems to have found a genuine case of an incorrect link. Fix based on comment above: #10640 (review) |
|
Approving based on fix in #10906 |
|
Phew! It normally doesn't take this much to get a 4 character change in. :) That's for the fix @ruborg. |
No description provided.