Doubleclick/AdSense FF: Append error parameter to ad url if XHR CORS fails #10654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eshienbrood to take first review pass |
eshienbrood
approved these changes
Aug 1, 2017
glevitzky
approved these changes
Aug 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When XHR CORS ad request fails due to network error, append to ad url parameter aet=n used for frame GET within layoutCallback to help differentiate ad requests due to network failure. Done via the onNetworkFailure function within AmpA4A allowing for specifying new ad url as well as if frame GET should be attempted within layoutCallback (by default uses same url as CORS XHR and attempts frame GET fetch).
/cc @ampproject/a4a