Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove validator test that requires dispatch key AttrSpecs to define a value. #10681

Merged
merged 1 commit into from Jul 27, 2017
Merged

Remove validator test that requires dispatch key AttrSpecs to define a value. #10681

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 0 additions & 10 deletions validator/engine/validator_test.js
View file
Open in desktop
Expand Up @@ -455,16 +455,6 @@ function attrRuleShouldMakeSense(attrSpec, rules) {
expect(attrSpec.mandatory).toBeDefined();
expect(attrSpec.mandatory).toBe(true);
});
it('value or value_casei defined when dispatch_key is true', () => {
expect((attrSpec.value !== null) || (attrSpec.valueCasei !== null))
.toBe(true);
});
if (attrSpec.valueCasei !== null) {
it('value_casei must be lower case when dispatch_key is true', () => {
expect(attrSpec.valueCasei === attrSpec.valueCasei.toLowerCase())
.toBe(true);
});
}
}
// Value property names must be unique.
if (attrSpec.valueProperties !== null) {
Expand Down