AdSense/Doubleclick Fast Fetch update AMP creative metadata format change #10738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eshienbrood
reviewed
Aug 1, 2017
| const METADATA_STRINGS = [ | ||
| '<script amp-ad-metadata type=application/json>', | ||
| '<script type="application/json" amp-ad-metadata>', | ||
| '<script type=application/json amp-ad-metadata>']; |
There was a problem hiding this comment.
I'm wondering whether we just want to look for the first string, i.e., <script amp-metadata type=...>. According to an internal discussion in May, attribute names should always be sorted, and quotes should be omitted. I'm not sure that's become officially specified yet though. Most likely the best thing to do for now is to leave a TODO for later cleanup.
There was a problem hiding this comment.
I'd prefer to be backwards compatible for now but as mentioned in the description: "Add support for multiple versions (to be cleaned up in the future once stable)."
There was a problem hiding this comment.
I was thinking of a comment in the code itself. Are TODOs not a customary practice in this project?
eshienbrood
approved these changes
Aug 1, 2017
cvializ
pushed a commit
that referenced
this pull request
Aug 1, 2017
…ange (#10738) * handle metadata format change * set initial value for metadataStart var
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AMP creative transformation as part of validation includes metadata used for client-side render within friendly iframe. The metadata is wrapped in a json script tag whose format has changed from <script type=application/json amp-ad-metadata> to <script amp-ad-metadata type=application/json>. Add support for multiple versions (to be cleaned up in the future once stable).
/cc @ampproject/a4a